linux-kernel - RE: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware load fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MW5PR12MB55988C5FD23FB2380AF100168724A@MW5PR12MB5598.namprd12.prod.outlook.com>
Date:   Wed, 28 Jun 2023 07:38:56 +0000
From:   "Gaddam, Sarath Babu Naidu" <sarath.babu.naidu.gaddam@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "richardcochran@...il.com" <richardcochran@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "simon.horman@...igine.com" <simon.horman@...igine.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "vincent.cheng.xh@...esas.com" <vincent.cheng.xh@...esas.com>,
        "Katakam, Harini" <harini.katakam@....com>,
        "git (AMD-Xilinx)" <git@....com>
Subject: RE: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware load
 fails



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Friday, June 16, 2023 1:35 AM
> To: Gaddam, Sarath Babu Naidu <sarath.babu.naidu.gaddam@....com>
> Cc: richardcochran@...il.com; netdev@...r.kernel.org;
> simon.horman@...igine.com; andrew@...n.ch; linux-
> kernel@...r.kernel.org; vincent.cheng.xh@...esas.com; Katakam, Harini
> <harini.katakam@....com>; git (AMD-Xilinx) <git@....com>
> Subject: Re: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware
> load fails
> 
> On Wed, 14 Jun 2023 10:42:04 +0530 Sarath Babu Naidu Gaddam wrote:
> > Clock matrix driver can be probed before the rootfs containing
> > firmware/initialization .bin is available. The current driver throws a
> > warning and proceeds to execute probe even when firmware is not
> ready.
> > Instead, defer probe and wait for the .bin file to be available.
> 
> The first-step fix should be to try to get the FW into initramfs.
> For that driver should specify MODULE_FIRMWARE(), which I don't see
> here.

Thanks for the review. We will take MODULE_FIRMWARE as a separate patch.
We want defer probe to go first.

Thanks,
Sarath