linux-kernel - Re: [PATCH] fsi: master-ast-cf: Add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2023 09:37:57 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Juerg Haefliger <juerg.haefliger@...onical.com>
Cc:     jk@...abs.org, joel@....id.au, alistair@...ple.id.au,
        eajames@...ux.ibm.com, linux-fsi@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro

On Wed, Jun 28, 2023 at 09:29:46AM +0200, Juerg Haefliger wrote:
> On Wed, 28 Jun 2023 08:47:12 +0200
> Greg KH <gregkh@...uxfoundation.org> wrote:
> 
> > On Fri, Jun 16, 2023 at 02:20:40PM +0200, Juerg Haefliger wrote:
> > > The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> > > information via modinfo.
> > > 
> > > Signed-off-by: Juerg Haefliger <juerg.haefliger@...onical.com>
> > > ---
> > >  drivers/fsi/fsi-master-ast-cf.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
> > > index 5f608ef8b53c..1316bfd121fe 100644
> > > --- a/drivers/fsi/fsi-master-ast-cf.c
> > > +++ b/drivers/fsi/fsi-master-ast-cf.c
> > > @@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf = {
> > >  
> > >  module_platform_driver(fsi_master_acf);
> > >  MODULE_LICENSE("GPL");
> > > +
> > > +MODULE_FIRMWARE(FW_FILE_NAME);  
> > 
> > No need for the extra blank line, right?
> 
> Guess not.
> 
>  
> > And what commit id does this fix?
> 
> 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
> 
> Want me to send a v2?

Please do and properly add the fixes line and the cc: stable line so
that it will get backported correctly.

thanks,

greg k-h