linux-kernel - Re: [PATCH v3] block: add check that partition length needs to be aligned with block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230628083839.GA26606@lst.de>
Date:   Wed, 28 Jun 2023 10:38:39 +0200
From:   Christoph Hellwig <hch@....de>
To:     Min Li <min15.li@...sung.com>
Cc:     hch@....de, axboe@...nel.dk, dlemoal@...nel.org,
        gregkh@...uxfoundation.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...nel.org,
        willy@...radead.org
Subject: Re: [PATCH v3] block: add check that partition length needs to be
 aligned with block size

On Wed, Jun 28, 2023 at 04:34:42PM +0000, Min Li wrote:
> I will modify the blksz to unsigned int.
> For pre-existing start/length, is it ok to change them to sector_t?

They are long long in the UAPI, which is weird but has been that way
for a long time.  So I think we need checks for negative values
before they are shifted and converted to a sector_t.