linux-kernel - Re: [PATCH] mm/ksm: delete the redundant ksm_merging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c3bd72a0-6c19-b874-9942-2fc1e1f9a20b@redhat.com>
Date:   Wed, 28 Jun 2023 11:07:53 +0200
From:   David Hildenbrand <david@...hat.com>
To:     xu xin <xu.xin.sc@...il.com>, sunnanyong@...wei.com
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, wangkefeng.wang@...wei.com,
        yang.yang29@....com.cn, xu.xin16@....com.cn
Subject: Re: [PATCH] mm/ksm: delete the redundant ksm_merging_pages interafce
 in proc

On 28.06.23 05:12, xu xin wrote:
>> Message-ID: <20230627133542.2446285-1-sunnanyong@...wei.com> (raw)
>>
>> Since the ksm_merging_pages information already included in
>> /proc/<pid>/ksm_stat, we can delete /proc/<pid>/ksm_merging_pages to
>> make the directory more clean, and can save a little bit resources.
> 
> I think it's ok to remove it because this interface was not proposed for a long time.
> I believe its users are not many yet. The earlier we delete it, the better.
> 

Well ... it's been around since v5.19, which was released 1 year ago.

... not sure if the removal is worth the possible user space break.

-- 
Cheers,

David / dhildenb