linux-kernel - Re: [PATCH V2] mm: madvise: fix uneven accounting of psi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a80670c8-850c-e0f8-67d3-9d783a666076@quicinc.com>
Date:   Wed, 28 Jun 2023 16:20:09 +0530
From:   Charan Teja Kalla <quic_charante@...cinc.com>
To:     Johannes Weiner <hannes@...xchg.org>
CC:     <akpm@...ux-foundation.org>, <surenb@...gle.com>,
        <minchan@...nel.org>, <quic_pkondeti@...cinc.com>,
        <quic_smanapra@...cinc.com>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] mm: madvise: fix uneven accounting of psi

Thanks Johannes!!

On 6/27/2023 8:16 PM, Johannes Weiner wrote:
> Unless I'm missing something, this also includes inactive pages, which
> is undesirable. Shouldn't this be:
> 
> 		if (folio_test_active(folio))

My bad. Let me fix it.

> 			folio_set_workingset(folio);