linux-kernel - Re: [13/39] drm: renesas: shmobile: Rename input clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ebc3c30f-1ea5-5404-dbe0-1a153c580931@loongson.cn>
Date:   Wed, 28 Jun 2023 09:50:07 +0800
From:   Sui Jingfeng <suijingfeng@...ngson.cn>
To:     Geert Uytterhoeven <geert+renesas@...der.be>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Magnus Damm <magnus.damm@...il.com>
Cc:     linux-renesas-soc@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [13/39] drm: renesas: shmobile: Rename input clocks

Hi,

On 2023/6/22 17:21, Geert Uytterhoeven wrote:
> From: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
>
> Prepare for DT bindings by using more appropriate names for the input
> clocks.
>
> Note that all LDDCKR_ICKSEL_* definitions but the one for the bus clock
> are valid only for SH7724, so the clock selection code needs to be
> updated when extending clock support to other SoCs.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
> [geert: Add note]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
Reviewed-by: Sui Jingfeng <suijingfeng@...ngson.cn>
> ---
>   drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c
> index d272e6273c782178..007ba97cc7733c82 100644
> --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c
> +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_drv.c
> @@ -74,15 +74,15 @@ static int shmob_drm_setup_clocks(struct shmob_drm_device *sdev,
>   
>   	switch (clksrc) {
>   	case SHMOB_DRM_CLK_BUS:
> -		clkname = "bus_clk";
> +		clkname = "fck";
>   		sdev->lddckr = LDDCKR_ICKSEL_BUS;
>   		break;
>   	case SHMOB_DRM_CLK_PERIPHERAL:
> -		clkname = "peripheral_clk";
> +		clkname = "media";
>   		sdev->lddckr = LDDCKR_ICKSEL_MIPI;
>   		break;
>   	case SHMOB_DRM_CLK_EXTERNAL:
> -		clkname = NULL;
> +		clkname = "lclk";
>   		sdev->lddckr = LDDCKR_ICKSEL_HDMI;
>   		break;
>   	default:

-- 
Jingfeng