linux-kernel - Fwd: commit 9df9d2f0471b causes boot failure in pre-rc1 6.5 kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d9fb4a9-6c48-600c-f625-8ef66208090a@gmail.com>
Date:   Wed, 28 Jun 2023 21:06:22 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Regressions <regressions@...ts.linux.dev>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Rick Edgecombe <rick.p.edgecombe@...el.com>,
        Borislav Petkov <bp@...en8.de>
Subject: Fwd: commit 9df9d2f0471b causes boot failure in pre-rc1 6.5 kernel

Hi,

I notice a regression report on Bugzilla [1]. Quoting from it:

> Since yesterday my builds of the https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git no longer boot with a black screen immediately upon booting. Today I finished git bisecting the issue and arrived at the following:
> 
> 9df9d2f0471b4c4702670380b8d8a45b40b23a7d is the first bad commit
> commit 9df9d2f0471b4c4702670380b8d8a45b40b23a7d
> Author: Thomas Gleixner <tglx@...utronix.de>
> Date:   Wed Jun 14 01:39:39 2023 +0200
> 
>     init: Invoke arch_cpu_finalize_init() earlier
>     
>     X86 is reworking the boot process so that initializations which are not
>     required during early boot can be moved into the late boot process and out
>     of the fragile and restricted initial boot phase.
>     
>     arch_cpu_finalize_init() is the obvious place to do such initializations,
>     but arch_cpu_finalize_init() is invoked too late in start_kernel() e.g. for
>     initializing the FPU completely. fork_init() requires that the FPU is
>     initialized as the size of task_struct on X86 depends on the size of the
>     required FPU register buffer.
>     
>     Fortunately none of the init calls between calibrate_delay() and
>     arch_cpu_finalize_init() is relevant for the functionality of
>     arch_cpu_finalize_init().
>     
>     Invoke it right after calibrate_delay() where everything which is relevant
>     for arch_cpu_finalize_init() has been set up already.
>     
>     No functional change intended.
>     
>     Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
>     Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com>
>     Link: https://lore.kernel.org/r/20230613224545.612182854@linutronix.de
> 
>  init/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Since it might be relevant, my CPU is Intel Core i5-12400 with UEFI from december 2022 and the compiler is gcc (Gentoo Hardened 13.1.1_p20230527 p3) 13.1.1 20230527. If additional information such as the kernel configuration is required, let me know.

See Bugzilla for the full thread.

The reporter can't provide requested dmesg due to this is early
boot failure, unfortunately.

Nevertheless, this regression has already been taken care of on
Bugzilla, but to ensure it is tracked and doesn't get fallen through
cracks unnoticed, I'm adding it to regzbot:

#regzbot introduced: 9df9d2f0471b https://bugzilla.kernel.org/show_bug.cgi?id=217602
#regzbot title: early arch_cpu_finalize_init() cause immediate boot failure

Thanks.

[1]: https://bugzilla.kernel.org/show_bug.cgi?id=217602

-- 
An old man doll... just what I always wanted! - Clara