[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <92ae722f-c09b-120f-bc30-7452e87f5374@talpey.com>
Date: Wed, 28 Jun 2023 10:11:21 -0400
From: Tom Talpey <tom@...pey.com>
To: Dave Kleikamp <dave.kleikamp@...cle.com>,
"Dr. David Alan Gilbert" <linux@...blig.org>
Cc: sfrench@...ba.org, linux-cifs@...r.kernel.org,
jfs-discussion@...ts.sourceforge.net, linkinjeon@...nel.org,
linux-kernel@...r.kernel.org
Subject: Re: [Jfs-discussion] [PATCH 0/3] dedupe smb unicode files
On 6/28/2023 10:02 AM, Dave Kleikamp wrote:
> On 6/28/23 8:46AM, Dr. David Alan Gilbert wrote:
>> * Dr. David Alan Gilbert (dave@...blig.org) wrote:
>>> * Tom Talpey (tom@...pey.com) wrote:
>>>> On 6/27/2023 9:14 PM, linux@...blig.org wrote:
>>>>> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>>>>>
>>>>> The smb client and server code have (mostly) duplicated code
>>>>> for unicode manipulation, in particular upper case handling.
>>>>>
>>>>> Flatten this lot into shared code.
>>>>>
>>>>> There's some code that's slightly different between the two, and
>>>>> I've not attempted to share that - this should be strictly a no
>>>>> behaviour change set.
>>>>>
>>>>> I'd love to also boil out the same code from fs/jfs/ - but that's
>>>>> a thought for another time (and harder since there's no good test
>>>>> for it).
>>>>>
>>>>> Lightly tested with a module and a monolithic build, and just mounting
>>>>> itself.
>>>>>
>>>>> This dupe was found using PMD:
>>>>> https://pmd.github.io/pmd/pmd_userdocs_cpd.html
>>>>>
>>>>> Dave
>>>>>
>>>>> Dr. David Alan Gilbert (3):
>>>>> fs/smb: Remove unicode 'lower' tables
>>>>> fs/smb: Swing unicode common code from server->common
>>>>> fs/smb/client: Use common code in client
>>>>>
>>>>> fs/smb/client/cifs_unicode.c | 1 -
>>>>> fs/smb/client/cifs_unicode.h | 313
>>>>> +-----------------
>>>>> fs/smb/client/cifs_uniupr.h | 239 -------------
>>>>> fs/smb/common/Makefile | 1 +
>>>>> .../uniupr.h => common/cifs_unicode_common.c} | 156 +--------
>>>>> fs/smb/common/cifs_unicode_common.h | 279
>>>>> ++++++++++++++++
>>>>
>>>> So far so good, but please drop the "cifs_" prefix from this new file's
>>>> name, since its contents apply to later smb dialects as well.
>>>
>>> Sure.
>>
>> Actually, would you be ok with smb_unicode_common ? The reason is that
>> you end up with a module named unicode_common that sounds too generic.
>
> I'd suggest make it generic and move it to fs/nls/. I'd run it by the
> nls maintainers, but I don't think there are any.
I agree that would be best. If it stays in smb/common, with or
without extra filename decoration, it will still need to move
someday. But I have no strong preference on prefix apart from
not constraining it to a single protocol dialect.
Tom.
> Shaggy
>
>>
>> Dave
>>
>>> Dave
>>>
>>>> Tom.
>>>>
>>>>> fs/smb/server/unicode.c | 1 -
>>>>> fs/smb/server/unicode.h | 301
>>>>> +----------------
>>>>> 8 files changed, 298 insertions(+), 993 deletions(-)
>>>>> delete mode 100644 fs/smb/client/cifs_uniupr.h
>>>>> rename fs/smb/{server/uniupr.h => common/cifs_unicode_common.c}
>>>>> (50%)
>>>>> create mode 100644 fs/smb/common/cifs_unicode_common.h
>>>>>
>>> --
>>> -----Open up your eyes, open up your mind, open up your code -------
>>> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
>>> \ dave @ treblig.org | | In Hex /
>>> \ _________________________|_____ http://www.treblig.org |_______/
>
Powered by blists - more mailing lists