[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZJxF77bNAQ79OpWs@smile.fi.intel.com>
Date: Wed, 28 Jun 2023 17:38:39 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Giovanni Cabiddu <giovanni.cabiddu@...el.com>
Cc: You Kangren <youkangren@...o.com>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
Tom Zanussi <tom.zanussi@...ux.intel.com>,
Damian Muszynski <damian.muszynski@...el.com>,
Srinivas Kerekare <srinivas.kerekare@...el.com>,
"open list:QAT DRIVER" <qat-linux@...el.com>,
"open list:CRYPTO API" <linux-crypto@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
opensource.kernel@...o.com
Subject: Re: [PATCH] crypto: qat - use min() in fw loader
On Wed, Jun 28, 2023 at 02:11:53PM +0100, Giovanni Cabiddu wrote:
> On Wed, Jun 28, 2023 at 01:46:44PM +0300, Andy Shevchenko wrote:
> > On Tue, Jun 27, 2023 at 03:17:24PM +0800, You Kangren wrote:
...
> > min_t() can be dangerous some times.
> >
> > To make it robust I would suggest to use min() and mark UWORD_CPYBUF_SIZE
> > with U suffix to make the type the same.
> Thanks. I reworked it, added a missing include and ordered the includes
> in the file.
I think it should be two patches then, but it's up to you and subsystem
maintainer.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists