[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZJxHTHCq0T/y+dG0@smile.fi.intel.com>
Date: Wed, 28 Jun 2023 17:44:28 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Amadeusz Sławiński
<amadeuszx.slawinski@...ux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@...gle.com>,
Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
alsa-devel@...a-project.org, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org,
Cezary Rojewski <cezary.rojewski@...el.com>,
Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
Kai Vehmanen <kai.vehmanen@...ux.intel.com>
Subject: Re: [RFC PATCH 1/8] PCI: Add Intel Audio DSP devices to pci_ids.h
On Wed, Jun 28, 2023 at 10:51:28PM +0200, Amadeusz Sławiński wrote:
> Those IDs are mostly sprinkled between HDA, Skylake, SOF and avs drivers.
> Almost every use contains additional comments to identify to which
> platform those IDs refer to. Add those IDs to pci_ids.h header, so that
> there is one place which defines those names.
...
> #define PCI_DEVICE_ID_INTEL_5400_FBD0 0x4035
> #define PCI_DEVICE_ID_INTEL_5400_FBD1 0x4036
> +#define PCI_DEVICE_ID_INTEL_HDA_JSL_N 0x4dc8
> +#define PCI_DEVICE_ID_INTEL_HDA_TGL_H 0x43c8
> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_0 0x4b55
> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_3 0x4b58
Can it be kept sorted by a value?
Didn't check the full list, though.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists