lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <66eef649-fe8c-4a17-e8fa-1f38f699dd83@kernel.dk>
Date:   Wed, 28 Jun 2023 08:58:59 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Thomas Weißschuh <thomas@...ch.de>
Cc:     Dave Chinner <david@...morbit.com>,
        Kent Overstreet <kent.overstreet@...ux.dev>,
        torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-bcachefs@...r.kernel.org,
        Christoph Hellwig <hch@....de>
Subject: Re: [GIT PULL] bcachefs

On 6/28/23 8:48 AM, Thomas Weißschuh wrote:
> On 2023-06-28 08:40:27-0600, Jens Axboe wrote:
>> On 6/27/23 4:05?PM, Dave Chinner wrote:
>> [..]
> 
>>> There should be no reason to need to specify the filesystem type for
>>> filesystems that blkid recognises. from common/config:
>>>
>>>         # Autodetect fs type based on what's on $TEST_DEV unless it's been set
>>>         # externally
>>>         if [ -z "$FSTYP" ] && [ ! -z "$TEST_DEV" ]; then
>>>                 FSTYP=`blkid -c /dev/null -s TYPE -o value $TEST_DEV`
>>>         fi
>>>         FSTYP=${FSTYP:=xfs}
>>>         export FSTYP
>>
>> Gotcha, yep it's because blkid fails to figure it out.
> 
> This needs blkid/util-linux version 2.39 which is fairly new.
> If it doesn't work with that, it's a bug.

Got it, looks like I have 2.38.1 here.

-- 
Jens Axboe


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ