linux-kernel - Re: [PATCH v6 1/3] dt-bindings: PCI: qcom: ep: Add interconnects path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230628153406.GA517577-robh@kernel.org>
Date:   Wed, 28 Jun 2023 09:34:06 -0600
From:   Rob Herring <robh@...nel.org>
To:     Krishna Chaitanya Chundru <quic_krichai@...cinc.com>
Cc:     quic_ramkri@...cinc.com, linux-pci@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>, quic_nitegupt@...cinc.com,
        linux-arm-msm@...r.kernel.org,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        devicetree@...r.kernel.org, helgaas@...nel.org,
        Manivannan Sadhasivam <mani@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Conor Dooley <conor+dt@...nel.org>, quic_skananth@...cinc.com,
        krzysztof.kozlowski@...aro.org, manivannan.sadhasivam@...aro.org,
        quic_vbadigan@...cinc.com, Bjorn Andersson <andersson@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/3] dt-bindings: PCI: qcom: ep: Add interconnects path

On Wed, Jun 28, 2023 at 10:45:03AM +0530, Krishna Chaitanya Chundru wrote:
> 
> On 6/28/2023 8:47 AM, Rob Herring wrote:
> > On Wed, 28 Jun 2023 07:49:28 +0530, Krishna chaitanya chundru wrote:
> > > Some platforms may not boot if a device driver doesn't
> > > initialize the interconnect path. Mostly it is handled
> > > by the bootloader but we have starting to see cases
> > > where bootloader simply ignores them.
> > > 
> > > Add the "pcie-mem" interconnect path as a required property
> > > to the bindings.
> > > 
> > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@...cinc.com>
> > > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> > > ---
> > >   Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 13 +++++++++++++
> > >   1 file changed, 13 insertions(+)
> > > 
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> > 
> > yamllint warnings/errors:
> > 
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/clock/milbeaut-clock.example.dtb: /example-2/serial@...00010: failed to match any schema with compatible: ['socionext,milbeaut-usio-uart']
> > Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.example.dtb: /example-1/syscon@...00000: failed to match any schema with compatible: ['sprd,sc9863a-glbregs', 'syscon', 'simple-mfd']
> > Documentation/devicetree/bindings/leds/common.example.dtb: /example-2/i2c/led-controller@30: failed to match any schema with compatible: ['panasonic,an30259a']
> > Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb: /example-0/cpu: failed to match any schema with compatible: ['cpu-driver']
> > Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb: /example-0/codec: failed to match any schema with compatible: ['codec-driver']
> > Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.example.dtb: /example-0/avs-monitor@...d2000: failed to match any schema with compatible: ['brcm,bcm2711-avs-monitor', 'syscon', 'simple-mfd']
> > Documentation/devicetree/bindings/thermal/imx-thermal.example.dtb: /example-0/anatop@...8000: failed to match any schema with compatible: ['fsl,imx6q-anatop', 'syscon', 'simple-mfd']
> > Documentation/devicetree/bindings/i2c/qcom,i2c-cci.example.dtb: /example-0/cci@...a000/i2c-bus@...amera@60: failed to match any schema with compatible: ['ovti,ov7251']
> > Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['ti,twl6035-pmic', 'ti,palmas-pmic']
> > Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['ti,twl6035-pmic', 'ti,palmas-pmic']
> > Documentation/devicetree/bindings/input/mediatek,pmic-keys.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['mediatek,mt6397']
> > Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.example.dtb: /example-0/pmic@0: failed to match any schema with compatible: ['sprd,sc2731']
> > Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@...00000: failed to match any schema with compatible: ['ti,omap-sdma']
> > Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@...02b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar']
> > Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.example.dtb: /example-0/memory-controller@...10000/ethernet@6: failed to match any schema with compatible: ['davicom,dm9000']
> > Documentation/devicetree/bindings/arm/hisilicon/controller/cpuctrl.example.dtb: /example-0/cpuctrl@...000/clock@0: failed to match any schema with compatible: ['hisilicon,hix5hd2-clock']
> > Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.example.dtb: /example-0/system-controller@...000/clock@0: failed to match any schema with compatible: ['hisilicon,hi3620-clock']
> > Documentation/devicetree/bindings/arm/hisilicon/controller/hi3798cv200-perictrl.example.dtb: /example-0/peripheral-controller@...0000/phy@850: failed to match any schema with compatible: ['hisilicon,hi3798cv200-combphy']
> > Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: /example-0/parent/i2c/camera@36: failed to match any schema with compatible: ['ovti,ov5695']
> > Documentation/devicetree/bindings/net/marvell,mvusb.example.dtb: /example-0/usb/mdio@...witch@0: failed to match any schema with compatible: ['marvell,mv88e6190']
> > Documentation/devicetree/bindings/net/qca,ar71xx.example.dtb: /example-0/ethernet@...00000/mdio/switch@10: failed to match any schema with compatible: ['qca,ar9331-switch']
> > Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.example.dtb: /example-0/iomcu@...7e000: failed to match any schema with compatible: ['hisilicon,hi3660-iomcu', 'syscon']
> > 
> > doc reference errors (make refcheckdocs):
> > 
> > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1687918770-28416-2-git-send-email-quic_krichai@quicinc.com
> > 
> > The base for the series is generally the latest rc1. A different dependency
> > should be noted in *this* patch.
> > 
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> > 
> > pip3 install dtschema --upgrade
> > 
> > Please check and re-submit after running the above command yourself. Note
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your schema.
> > 
> Hi Rob,
> 
> Can you please verify again I don't see any errors when I ran it

Yep, you can ignore this.

Rob