linux-kernel - Re: [PATCH 6/7] xfs: Convert to bdev_logical_block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZJxit/naWMq3v6OU@redhat.com>
Date:   Wed, 28 Jun 2023 11:41:27 -0500
From:   Bill O'Donnell <billodo@...hat.com>
To:     Yangtao Li <frank.li@...o.com>
Cc:     axboe@...nel.dk, song@...nel.org, viro@...iv.linux.org.uk,
        brauner@...nel.org, xiang@...nel.org, chao@...nel.org,
        huyue2@...lpad.com, jefflexu@...ux.alibaba.com, hch@...radead.org,
        djwong@...nel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
        linux-xfs@...r.kernel.org
Subject: Re: [PATCH 6/7] xfs: Convert to bdev_logical_block_mask()

On Wed, Jun 28, 2023 at 05:34:59PM +0800, Yangtao Li wrote:
> Use bdev_logical_block_mask() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@...o.com>

Reviewed-by: Bill O'Donnell <bodonnel@...hat.com>

> ---
>  fs/xfs/xfs_buf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 15d1e5a7c2d3..f784daa21219 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -1968,7 +1968,7 @@ xfs_setsize_buftarg(
>  
>  	/* Set up device logical sector size mask */
>  	btp->bt_logical_sectorsize = bdev_logical_block_size(btp->bt_bdev);
> -	btp->bt_logical_sectormask = bdev_logical_block_size(btp->bt_bdev) - 1;
> +	btp->bt_logical_sectormask = bdev_logical_block_mask(btp->bt_bdev);
>  
>  	return 0;
>  }
> -- 
> 2.39.0
>