[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9f5b205a-c5d5-e66b-8ba8-57823486eaef@linaro.org>
Date: Wed, 28 Jun 2023 17:43:33 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: krzysztof.kozlowski+dt@...aro.org, andersson@...nel.org,
broonie@...nel.org, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org, dmitry.baryshkov@...aro.org,
johan+linaro@...nel.org, perex@...ex.cz, tiwai@...e.com,
lgirdwood@...il.com, ckeepax@...nsource.cirrus.com,
kuninori.morimoto.gx@...esas.com, linux-kernel@...r.kernel.org,
pierre-louis.bossart@...ux.intel.com, alsa-devel@...a-project.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: q6apm: add firmware-name bindings
On 28/06/2023 16:54, Rob Herring wrote:
> On Wed, Jun 28, 2023 at 11:26:19AM +0100, Srinivas Kandagatla wrote:
>> Add bindings to get firmare-name from DT, this will provide more flexibility
>> to specify platform specific firmware file name and location. Also this brings
>> tplg firmware name inline with other board specific firmware locations.
>
> tplg?
Topology, will update this in next version.
>
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
>> ---
>> Documentation/devicetree/bindings/sound/qcom,q6apm.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
>> index ef1965aca254..c783451145ef 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
>> @@ -31,6 +31,10 @@ properties:
>> unevaluatedProperties: false
>> description: Qualcomm DSP audio ports
>>
>> + firmware-name:
>> + $ref: /schemas/types.yaml#/definitions/string
>
> Already has a type, so you can drop.
thankyou removed this now, but all the existing yaml still have this.
>
> No default? Or pattern it should match?
no, its going to be hard to come up with a pattern to match file name or
path for firmware.
>
>> + description: Audio Topology Firmware name
>> +
>> '#sound-dai-cells':
>> const: 0
>>
>> @@ -38,6 +42,7 @@ required:
>> - compatible
>> - bedais
>> - dais
>> + - firmware-name
>
> Causes warnings. Test you bindings.
yes, examples need updating, will do that in next spin.
--srini
>
>>
>> unevaluatedProperties: false
>>
>> --
>> 2.21.0
>>
Powered by blists - more mailing lists