linux-kernel - RE: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index for ch9 udc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2023 17:04:00 +0000
From:   Leo Li <leoyang.li@....com>
To:     Ma Ke <make_ruc2021@....com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index for ch9
 udc



> -----Original Message-----
> From: Ma Ke <make_ruc2021@....com>
> Sent: Wednesday, June 28, 2023 3:15 AM
> To: Leo Li <leoyang.li@....com>
> Cc: gregkh@...uxfoundation.org; linux-usb@...r.kernel.org; linuxppc-
> dev@...ts.ozlabs.org; linux-kernel@...r.kernel.org; Ma Ke
> <make_ruc2021@....com>
> Subject: [PATCH] usb: gadget: fsl_qe_udc: validate endpoint index for ch9
> udc
> 
> We should verify the bound of the array to assure that host may not
> manipulate the index to point past endpoint array.
> 
> Signed-off-by: Ma Ke <make_ruc2021@....com>
> ---
>  drivers/usb/gadget/udc/fsl_qe_udc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c
> b/drivers/usb/gadget/udc/fsl_qe_udc.c
> index 3b1cc8fa30c8..f4e5cbd193b7 100644
> --- a/drivers/usb/gadget/udc/fsl_qe_udc.c
> +++ b/drivers/usb/gadget/udc/fsl_qe_udc.c
> @@ -1959,6 +1959,8 @@ static void ch9getstatus(struct qe_udc *udc, u8
> request_type, u16 value,
>  	} else if ((request_type & USB_RECIP_MASK) ==
> USB_RECIP_ENDPOINT) {
>  		/* Get endpoint status */
>  		int pipe = index & USB_ENDPOINT_NUMBER_MASK;
> +		if (pipe >= USB_MAX_ENDPOINTS)
> +			goto stall;

Thanks.  This seems to be the right thing to do.  But normally we don't mix declarations with code within a code block.  Could we re-arrange the code a little bit so declarations stay on top?

>  		struct qe_ep *target_ep = &udc->eps[pipe];
>  		u16 usep;
> 
> --
> 2.37.2