linux-kernel - Re: build failure after commit eb0481bbc4ce ("objtool: Fix reloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230628181019.cmgfbygxfvwamzur@treble>
Date:   Wed, 28 Jun 2023 11:10:19 -0700
From:   Josh Poimboeuf <jpoimboe@...nel.org>
To:     Michal Kubecek <mkubecek@...e.cz>
Cc:     Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org
Subject: Re: build failure after commit eb0481bbc4ce ("objtool: Fix
 reloc_hash size")

On Wed, Jun 28, 2023 at 07:26:59PM +0200, Michal Kubecek wrote:
> I digged some more and my guess is that the problem is that
> elf_open_read() does
> 
> 	memset(elf, 0, offsetof(struct elf, sections));
> 
> but commit eb0481bbc4ce ("objtool: Fix reloc_hash size") added
> num_relocs after sections so that it is not zeroed (0xbabababababababa
> is probably some kind of poison).

Argh, that memset() is subtle as heck.  Peter, why?!?

-- 
Josh