[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fa12dd5d-af9d-235d-a6c7-3dcf690dcd67@quicinc.com>
Date: Thu, 29 Jun 2023 14:53:42 -0700
From: Anjelique Melendez <quic_amelende@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Rob Herring <robh@...nel.org>
CC: <pavel@....cz>, <lee@...nel.org>, <thierry.reding@...il.com>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<agross@...nel.org>, <andersson@...nel.org>,
<konrad.dybcio@...aro.org>, <u.kleine-koenig@...gutronix.de>,
<linux-leds@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
<linux-pwm@...r.kernel.org>
Subject: Re: [PATCH 1/7] dt-bindings: soc: qcom: Add qcom-pbs bindings
On 6/29/2023 1:45 AM, Dmitry Baryshkov wrote:
> On 29/06/2023 04:19, Anjelique Melendez wrote:
>>
>>
>> On 6/26/2023 6:58 AM, Rob Herring wrote:
>>> On Wed, Jun 21, 2023 at 11:59:45AM -0700, Anjelique Melendez wrote:
>>>> Add binding for the Qualcomm Programmable Boot Sequencer device.
>>>>
>>>> Signed-off-by: Anjelique Melendez <quic_amelende@...cinc.com>
>>>> ---
>>>> .../bindings/soc/qcom/qcom-pbs.yaml | 41 +++++++++++++++++++
>>>> 1 file changed, 41 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml
>>>> new file mode 100644
>>>> index 000000000000..0a89c334f95c
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml
>>>> @@ -0,0 +1,41 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: http://devicetree.org/schemas/soc/qcom/qcom-pbs.yaml#
>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>> +
>>>> +title: Qualcomm Technologies, Inc. PBS
>>>> +
>>>> +maintainers:
>>>> + - Anjelique Melendez <quic_amelende@...cinc.com>
>>>> +
>>>> +description: |
>>>> + Qualcomm PBS (programmable boot sequencer) supports triggering sequences
>>>> + for clients upon request.
>>>> +
>>>> +properties:
>>>> + compatible:
>>>> + const: qcom,pbs
>>>> +
>>>> + reg:
>>>> + description: |
>>>> + Base address of the PBS peripheral.
>>>> + maxItems: 1
>>>> +
>>>> +required:
>>>> + - compatible
>>>> + - reg
>>>> +
>>>> +additionalProperties: false
>>>> +
>>>> +examples:
>>>> + - |
>>>> + pmic {
>>>> + #address-cells = <1>;
>>>> + #size-cells = <0>;
>>>> +
>>>> + qcom,pbs@...0 {
>>>> + compatible = "qcom,pbs";
>>>> + reg = <0x7400>;
>>>> + };
>>>
>>> Why do you need a child node for this? Is there more than 1 instance in
>>> a PMIC? Every sub-function of a PMIC doesn't have to have a DT node.
>>>
>>
>> We currently have another downstream driver (which is planned to get upstreamed)
>> which also needs a handle to a pbs device in order to properly trigger events.
>
> Does it have to be a separate driver? Or is it a part of the LPG driver, just being artificially split away?
Sure, I just discussed with team and we are ok with removing this as a separate driver. Will have that
for next version.
>
>>
>>> Rob
>>
>>
>>
>
Powered by blists - more mailing lists