linux-kernel - Re: [PATCH v3 0/3] Fix some checkpatch issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69a90f88-634a-4126-8d33-e770fcc4b686@kadam.mountain>
Date:   Thu, 29 Jun 2023 10:40:40 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Franziska Näpelt 
        <franziska.naepelt@...glemail.com>
Cc:     Philipp Hortmann <philipp.g.hortmann@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        eperi1024@...il.com, hdegoede@...hat.com, quic_vjakkam@...cinc.com,
        johannes.berg@...el.com, tegongkang@...il.com,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH v3 0/3] Fix some checkpatch issues

On Wed, Jun 28, 2023 at 06:38:03PM +0200, Franziska Näpelt wrote:
> 
> Do you want me to submit v4 to fix the email address as well as the subject of
> the cover letter or are you ok with me promising to make it properly the next
> time? ;)

Philipp is not the person to ask, it's Greg.

Yes, you are going to need to resend because of the email address thing.

Probably the cover letter is not a reason to resend, but since you are
resending then please fix that as well.

The reason why we insist that you resend is a couple things:
1) This is a checkpatch change to staging so we assume that you're just
   doing it to learn how patches are supposed to be sent.  So this is an
   educational opportunity.  ;)
2) Greg maintains staging, usb, serial and -stable.  He's super busy.
   It doesn't scale to hand edit patches.  Some maintainers are less
   busy so they can fix trivial stuff like this but in staging you will
   need to resend.  Also if it were a security fix maybe I would step
   in and help you fix your patch but since it's just a checkpatch thing
   no one is going to edit your patch.

Right now the merge window is open so Greg isn't going to see your patch
for a few weeks.  When he does he will press the button on his keyboard
which sends an automatic reply about the email address thing and deletes
the thread from his inbox.

regards,
dan carpenter