linux-kernel - Re: [PATCH v4 4/4] ublk: add zone append

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cefae2c3-c8b5-f5ff-13dc-e8527ca2346f@kernel.org>
Date:   Thu, 29 Jun 2023 18:43:10 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     "Andreas Hindborg (Samsung)" <nmi@...aspace.dk>,
        Ming Lei <ming.lei@...hat.com>
Cc:     Hans Holmberg <Hans.Holmberg@....com>,
        Aravind Ramesh <Aravind.Ramesh@....com>,
        Jens Axboe <axboe@...nel.dk>,
        "open list:BLOCK LAYER" <linux-block@...r.kernel.org>,
        Christoph Hellwig <hch@...radead.org>,
        Matias Bjorling <Matias.Bjorling@....com>,
        open list <linux-kernel@...r.kernel.org>, gost.dev@...sung.com,
        Minwoo Im <minwoo.im.dev@...il.com>
Subject: Re: [PATCH v4 4/4] ublk: add zone append

On 6/29/23 18:17, Andreas Hindborg (Samsung) wrote:
> 
> Ming Lei <ming.lei@...hat.com> writes:
> 
>> On Wed, Jun 28, 2023 at 09:06:49PM +0200, Andreas Hindborg wrote:
>>> From: Andreas Hindborg <a.hindborg@...sung.com>
>>>
>>> Add zone append feature to ublk. This feature uses the `addr` field of `struct
>>> ublksrv_io_cmd`. Therefore ublk must be used with the user copy
>>> feature (UBLK_F_USER_COPY) for zone append to be available. Without this
>>> feature, ublk will fail zone append requests.
>>
>> Given zone append is a must, please fail to add device in case of zoned
>> and !user_copy, then we can make fast IO code path clean.
> 
> I will squash the patches and reject zone support if not user copy is
> enabled 👍

Or if !CONFIG_BLK_DEV_ZONED or if the user specifies a bad parameter (invalid
limits etc).

-- 
Damien Le Moal
Western Digital Research