linux-kernel - Re: [PATCH v3] block: add check that partition length needs to be aligned with block size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6a9d6824-b1f1-c711-2e24-cac48eefd9e9@kernel.org>
Date:   Thu, 29 Jun 2023 10:15:53 +0900
From:   Damien Le Moal <dlemoal@...nel.org>
To:     Yu Kuai <yukuai1@...weicloud.com>, Min Li <min15.li@...sung.com>,
        hch@....de
Cc:     axboe@...nel.dk, gregkh@...uxfoundation.org,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...nel.org, willy@...radead.org,
        "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH v3] block: add check that partition length needs to be
 aligned with block size

On 6/29/23 10:04, Yu Kuai wrote:
> Hi,
> 
> 在 2023/06/29 1:07, Min Li 写道:
>> On Mon, Jun 28, 2023 at 04:48:36PM +0000, Christoph Hellwig  wrote:
>>> They are long long in the UAPI, which is weird but has been that way
>>> for a long time.  So I think we need checks for negative values
>>> before they are shifted and converted to a sector_t.
>>
>> Do you mean that we need to check if p.start and p.length are negative?
>>
> 
> Perhaps this patch will make sense.
> 
> https://lore.kernel.org/all/20230525072041.3701176-1-zhongjinghua@huawei.com/

+ adding to it the logical block size alignment checks.

> 
> Thanks,
> Kuai
>> Thanks for your reply
>>
>> Min li
>> .
>>
> 

-- 
Damien Le Moal
Western Digital Research