linux-kernel - Re: [PATCH v2 1/1] serial: 8250: Preserve original value of DLF register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2023 14:06:19 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     ruihongluo <colorsu1922@...il.com>
Cc:     gregkh@...uxfoundation.org, ilpo.jarvinen@...ux.intel.com,
        jirislaby@...nel.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, luoruihong@...omi.com,
        wengjinfei@...omi.com, weipengliang@...omi.com
Subject: Re: [PATCH v2 1/1] serial: 8250: Preserve original value of DLF
 register

On Thu, Jun 29, 2023 at 05:42:05PM +0800, ruihongluo wrote:
> This commit is aimed at preserving the original value of the
> DLF(Divisor Latch Fraction Register). When the DLF register is
> modified without preservation, it can disrupt the baudrate settings
> established by firmware or bootloader , leading to data corruption
> and the generation of unreadable or distorted characters.

> Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
> 

To make it a tag you should avoid blank lines in the tag block.

> Signed-off-by: ruihongluo <luoruihong@...omi.com>
> ---
> v2:
> - added fixes tag

Actually not. See above.

And what about the  rest of the comments?

...

> Just wanted to drop a quick note to say thanks for your help with git
> send-email and code modifications.
> Your assistance on the details was much appreciated.

You're welcome!

> Ruihong Luo

This seems needs to be in your Git config:

$ cat ~/.gitconfig
[user]
	name = Ruihong Luo
	email = luoruihon@...omi.com

-- 
With Best Regards,
Andy Shevchenko