linux-kernel - Re: [PATCH v2] serial: 8250: Preserve original value of DLF register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZJ2B6I+ShqyJJJ+o@smile.fi.intel.com>
Date:   Thu, 29 Jun 2023 16:06:48 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Ruihong Luo <colorsu1922@...il.com>
Cc:     gregkh@...uxfoundation.org, ilpo.jarvinen@...ux.intel.com,
        jirislaby@...nel.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org, luoruihong@...omi.com,
        weipengliang@...omi.com, wengjinfei@...omi.com
Subject: Re: [PATCH v2] serial: 8250: Preserve original value of DLF register

On Thu, Jun 29, 2023 at 08:35:30PM +0800, Ruihong Luo wrote:
> This commit is aimed at preserving the original value of the

Preserve the original value...

> DLF(Divisor Latch Fraction Register). When the DLF register is

Divisor Latch Fraction (DLF) register...

> modified without preservation, it can disrupt the baudrate settings
> established by firmware or bootloader , leading to data corruption

...bootloader, leading...

> and the generation of unreadable or distorted characters.

> Fixes: 701c5e73b296 ("serial: 8250_dw: add fractional divisor support")
> Signed-off-by: Ruihong Luo <luoruihong@...omi.com>
> ---
> v2:
> - add a tag

It's a v3 and still some comments are not (yet) addressed:
1) your from header in email != SoB;
2) do not use In-reply-to email header for the new patch versions;
3) the commit message should be amended as I pointed out above again.

It will go nowhere if you continue ignoring reviewers' comments.

-- 
With Best Regards,
Andy Shevchenko