linux-kernel - Re: [PATCH] mm: memory-failure: fix unexpected return value in soft_offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2023 09:48:32 +0800
From:   Miaohe Lin <linmiaohe@...wei.com>
To:     Naoya Horiguchi <naoya.horiguchi@...ux.dev>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        <naoya.horiguchi@....com>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: memory-failure: fix unexpected return value in
 soft_offline_page()

On 2023/6/28 19:06, Naoya Horiguchi wrote:
> On Wed, Jun 28, 2023 at 09:56:38AM +0800, Miaohe Lin wrote:
>> On 2023/6/28 3:30, Andrew Morton wrote:
>>> On Tue, 27 Jun 2023 19:28:08 +0800 Miaohe Lin <linmiaohe@...wei.com> wrote:
>>>
>>>> When page_handle_poison() fails to handle the hugepage or free page in
>>>> retry path, soft_offline_page() will return 0 while -EBUSY is expected
>>>> in this case.
>>>
>>> What are the user visible effects of the bug?
>>
>> The user will think soft_offline_page succeeds while it failed in fact. So user
>> will not try again later in this case.
> 
> I think that it's helpful to put this in patch descrition so that maintainers can
> easily guess the impact of this patch.

Thanks for your review and advice. Will add it if v2 is needed.

> 
> Anyway, the patch looks good to me, thank you.
> 
> Acked-by: Naoya Horiguchi <naoya.horiguchi@....com>

Thanks Naoya.