linux-kernel - Re: [PATCH] sysctl: fix unused proc_cap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29968249-3fce-d53f-4515-1c7b815cd4b4@tessares.net>
Date:   Thu, 29 Jun 2023 17:00:42 +0200
From:   Matthieu Baerts <matthieu.baerts@...sares.net>
To:     Arnd Bergmann <arnd@...nel.org>,
        Luis Chamberlain <mcgrof@...nel.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Peter Zijlstra <peterz@...radead.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Huacai Chen <chenhuacai@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysctl: fix unused proc_cap_handler() function warning

Hi Arnd,

On 07/06/2023 14:08, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Since usermodehelper_table() is marked static now, we get a
> warning about it being unused when SYSCTL is disabled:
> 
> kernel/umh.c:497:12: error: 'proc_cap_handler' defined but not used [-Werror=unused-function]

Thank you for the patch!

We also hit the same issue on our side after today's sync with Linus'
tree. I confirm this patch fixes the issue.

Tested-by: Matthieu Baerts <matthieu.baerts@...sares.net>

I didn't see this patch applied in Luis' sysctl-next branch, do you know
who is taking care of it?

> Just move it inside of the same #ifdef.
> 
> Fixes: e6944e3b75df7 ("sysctl: move umh sysctl registration to its own file")

A small detail: it looks like the SHA has been modified, it should be
861dc0b46432 instead of e6944e3b75df7:

Fixes: 861dc0b46432 ("sysctl: move umh sysctl registration to its own file")

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net