linux-kernel - Re: [PATCH v2 1/1] Add a new sysctl to disable io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0c8d74a-dcfe-78a7-74bd-4447ed6944dc@acm.org>
Date:   Thu, 29 Jun 2023 08:15:52 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Matteo Rizzo <matteorizzo@...gle.com>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, io-uring@...r.kernel.org
Cc:     jordyzomer@...gle.com, evn@...gle.com, poprdi@...gle.com,
        corbet@....net, axboe@...nel.dk, asml.silence@...il.com,
        akpm@...ux-foundation.org, keescook@...omium.org,
        rostedt@...dmis.org, dave.hansen@...ux.intel.com,
        ribalda@...omium.org, chenhuacai@...nel.org, steve@....org,
        gpiccoli@...lia.com, ldufour@...ux.ibm.com, bhe@...hat.com,
        oleksandr@...alenko.name
Subject: Re: [PATCH v2 1/1] Add a new sysctl to disable io_uring system-wide

On 6/29/23 06:27, Matteo Rizzo wrote:
> +static int __read_mostly sysctl_io_uring_disabled;

Shouldn't this be a static key instead of an int in order to minimize the
performance impact on the io_uring_setup() system call? See also
Documentation/staging/static-keys.rst.

Thanks,

Bart.