linux-kernel - Re: [PATCH] fs/vboxsf: Replace kmap() with kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <649ce8cc8375e_92a162947@iweiny-mobl.notmuch>
Date:   Wed, 28 Jun 2023 19:13:32 -0700
From:   Ira Weiny <ira.weiny@...el.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
        Matthew Wilcox <willy@...radead.org>
CC:     Sumitra Sharma <sumitraartsy@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Ira Weiny <ira.weiny@...el.com>,
        "Deepak R Varma" <drv@...lo.com>
Subject: Re: [PATCH] fs/vboxsf: Replace kmap() with kmap_local_{page, folio}()

Fabio M. De Francesco wrote:
> On giovedì 29 giugno 2023 00:23:54 CEST Fabio M. De Francesco wrote:
> 
> [...]
> 
> > 
> > Shouldn't we call folio_lock() to lock the folio to be able to unlock with
> > folio_unlock()?
> 
> Sorry, I wanted to write "If so, I can't find either a folio_lock() or a 
> page_lock() in this filesystem.".

Check the documentation for read_folio:

	... "The filesystem should unlock the folio once the read has
	completed, whether it was successful or not." ...

Ira