[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c226d063-a8e9-d9b8-e070-bc15f7c7ec47@quicinc.com>
Date: Fri, 30 Jun 2023 10:52:13 +0530
From: Sricharan Ramabadhran <quic_srichara@...cinc.com>
To: Bjorn Helgaas <helgaas@...nel.org>
CC: <agross@...nel.org>, <andersson@...nel.org>,
<konrad.dybcio@...aro.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<sboyd@...nel.org>, <mturquette@...libre.com>, <mani@...nel.org>,
<lpieralisi@...nel.org>, <bhelgaas@...gle.com>,
<linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-clk@...r.kernel.org>,
<linux-pci@...r.kernel.org>
Subject: Re: [PATCH 1/4] pcie: qcom: Fix the macro
PARF_SLV_ADDR_SPACE_SIZE_2_3_3
Hi Bjorn,
On 6/23/2023 11:30 PM, Bjorn Helgaas wrote:
> On Fri, Jun 23, 2023 at 03:04:42PM +0530, Sricharan Ramabadhran wrote:
>> PARF_SLV_ADDR_SPACE_SIZE_2_3_3 macro used for IPQ8074
>> pcie slave addr size was initially set to 0x358, but
>> was wrongly changed to 0x168 as a part of
>> 'PCI: qcom: Sort and group registers and bitfield definitions'
>> Fixing it back to right value here.
>
> 1) Make your subject line match the history. For example, you're
> fixing 769e49d87b15 ("PCI: qcom: Sort and group registers ..."), so
> your subject line should start with "PCI: qcom: ...".
>
ok, will fix.
> 2) It doesn't look like 769e49d87b15 changed
> PARF_SLV_ADDR_SPACE_SIZE_2_3_3:
>
> $ git show 769e49d87b15 | grep PARF_SLV_ADDR_SPACE_SIZE_2_3_3
> +#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16C /* Register offset specific to IP ver 2.3.3 */
> -#define PARF_SLV_ADDR_SPACE_SIZE_2_3_3 0x16C /* Register offset specific to IP rev 2.3.3 */
>
> What am I missing here? Do you have another out-of-tree patch that
> broke this?
39171b33f652 ("PCI: qcom: Remove PCIE20_ prefix from
register definitions") broke it. Will change and post .
Regards,
Sricharan
Powered by blists - more mailing lists