linux-kernel - Re: [PATCH 6.4 00/29] 6.4.1-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023063030-overgrown-unfunded-7523@gregkh>
Date:   Fri, 30 Jun 2023 08:32:37 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     stable@...r.kernel.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        srw@...dewatkins.net, rwarsow@....de, conor@...nel.org
Subject: Re: [PATCH 6.4 00/29] 6.4.1-rc2 review

On Thu, Jun 29, 2023 at 11:20:45PM -0700, Linus Torvalds wrote:
> On Thu, 29 Jun 2023 at 22:59, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > Linus Torvalds <torvalds@...ux-foundation.org>
> >     gup: add warning if some caller would seem to want stack expansion
> 
> Did you decide to take that one after all?

For now, yes.

> It's not exactly wrong, and it might help find any odd cases, but I do
> suspect you can get syzbot etc to trigger the warning. It's designed
> to find crazy users, and syzbot is - pretty much by definition and by
> design - one of the craziest out there.

I think the "crazy users" reports might be triggered sooner with stable
updates than from your tree as well, so this might be a early-warning
type system.  I am pretty sure at least one "distro" has enabled it in
their kernel already as well.

But if this starts triggering a bunch of warnings, and they are causing
problems, I'll drop it (and recommend you revert it in your tree too.)

I wanted to be "warning compatible" here for now to ensure the backports
were working properly.

thanks,

greg k-h