linux-kernel - Re: [PATCH] mmc: sdhci-f-sdh30: Replace with sdhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c2a9e31-4ecc-17cb-3be7-8607dbc29329@socionext.com>
Date:   Fri, 30 Jun 2023 09:34:51 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Adrian Hunter <adrian.hunter@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: sdhci-f-sdh30: Replace with sdhci_pltfm

Hi Adrian,

On 2023/06/29 21:57, Adrian Hunter wrote:
> On 29/06/23 03:49, Kunihiko Hayashi wrote:
>> Even if sdhci_pltfm_pmops is specified for PM, this driver doesn't apply
>> sdhci_pltfm, so the structure is not correctly referenced in PM functions.
>> This applies sdhci_pltfm to this driver to fix this issue.
>>
>> - Call sdhci_pltfm_init() instead of sdhci_alloc_host() and
>>    other functions that covered by sdhci_pltfm.
>> - Move ops and quirks to sdhci_pltfm_data
>> - Replace sdhci_priv() with own private function sdhci_f_sdh30_priv().
>>
> 
> Does it need a Fixes tag?

Ah, I see. I'll add it in v2.

>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> 
> Otherwise:
> 
> Acked-by: Adrian Hunter <adrian.hunter@...el.com>

Thank you,

---
Best Regards
Kunihiko Hayashi