linux-kernel - Re: [PATCH 1/2] ALSA: hda/realtek: Add quirk for ASUS ROG GX650P

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6qpcq0i.wl-tiwai@suse.de>
Date:   Fri, 30 Jun 2023 10:29:01 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Luke D. Jones" <luke@...nes.dev>
Cc:     tiwai@...e.com, perex@...ex.cz, sbinding@...nsource.cirrus.com,
        andy.chi@...onical.com, tangmeng@...ontech.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ALSA: hda/realtek: Add quirk for ASUS ROG GX650P

On Fri, 30 Jun 2023 06:31:05 +0200,
Luke D. Jones wrote:
> 
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5883,7 +5883,7 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec,
>  		struct alc_spec *spec = codec->spec;
>  		spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
>  		alc255_set_default_jack_type(codec);
> -	} 
> +	}
>  	else
>  		alc_fixup_headset_mode(codec, fix, action);
>  }

This change looks irrelevant.  Could you drop it?
If it needs to be fixed, put in another cleanup patch.


thanks,

Takashi