[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75Vdpg8R0FtECk_bqdVMQW7Nz_EY0pacaL8PA+0Xcfkyt3Q@mail.gmail.com>
Date: Fri, 30 Jun 2023 12:28:05 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Pavan Kondeti <quic_pkondeti@...cinc.com>
Cc: Mukesh Ojha <quic_mojha@...cinc.com>, corbet@....net,
agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, keescook@...omium.org, tony.luck@...el.com,
gpiccoli@...lia.com, mathieu.poirier@...aro.org,
catalin.marinas@....com, will@...nel.org, linus.walleij@...aro.org,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-hardening@...r.kernel.org, linux-remoteproc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v4 20/21] firmware: qcom_scm: Refactor code to support
multiple download mode
On Fri, Jun 30, 2023 at 8:25 AM Pavan Kondeti <quic_pkondeti@...cinc.com> wrote:
> On Wed, Jun 28, 2023 at 06:04:47PM +0530, Mukesh Ojha wrote:
...
> > +static int set_download_mode(const char *val, const struct kernel_param *kp)
> > +{
> > + u32 old = download_mode;
> > + int ret;
> > +
> > + ret = sysfs_match_string(download_mode_name, val);
> > + if (ret < 0) {
> > + download_mode = old;
Why is this old variable needed at all?
> > + pr_err("qcom_scm: unknown download mode: %s\n", val);
> > + return -EINVAL;
> > + }
>
> minor nit: %s/-EINVAL/ret
>
> > + download_mode = ret;
> > + if (__scm)
> > + qcom_scm_set_download_mode(download_mode);
> > +
> > + return 0;
> > +}
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists