linux-kernel - Re: [PATCH v2] HID: logitech-hidpp: Add wired USB id for Logitech G502 Lightspeed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e97df981ab8871cf774c6be9e48d6ce3c0e80b7.camel@hadess.net>
Date:   Fri, 30 Jun 2023 13:13:11 +0200
From:   Bastien Nocera <hadess@...ess.net>
To:     Stuart Hayhurst <stuart.a.hayhurst@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>,
        Filipe Laíns <lains@...eup.net>
Subject: Re: [PATCH v2] HID: logitech-hidpp: Add wired USB id for Logitech
 G502 Lightspeed

On Thu, 2023-06-29 at 22:46 +0100, Stuart Hayhurst wrote:
> Previously, support for the G502 had been attempted in commit
> 27fc32f.
> This caused some issues and was reverted by addf338.
> Since then, a new version of this mouse has been released (Lightpseed
> Wireless), and works correctly.

Sorry to do this to you, but you might need to rework the description
again. The kernel maintainers are pretty strict when it comes to commit
references.

"If you want to refer to a specific commit, don't just refer to the
SHA-1 ID of the commit. Please also include the oneline summary of the
commit, to make it easier for reviewers to know what it is about."

https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

So 12-character short SHA-1 and the subject of the commit.
./scripts/checkpatch.pl should warn about that.

Should be:
27fc32fd9417 ("HID: logitech-hidpp: add USB PID for a few more
supported mice"
and
addf3382c47c ("Revert "HID: logitech-hidpp: add USB PID for a few more
supported mice"")

But you'll want to check those :)

> 
> This device has support for battery reporting with the driver
> 
> Signed-off-by: Stuart Hayhurst <stuart.a.hayhurst@...il.com>
> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 5e1a412fd28f..94a045ef8e50 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4598,6 +4598,8 @@ static const struct hid_device_id
> hidpp_devices[] = {
>  
>         { /* Logitech G403 Wireless Gaming Mouse over USB */
>           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC082) },
> +       { /* Logitech G502 Lightspeed Wireless Gaming Mouse over USB
> */
> +         HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC08D) },
>         { /* Logitech G703 Gaming Mouse over USB */
>           HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 0xC087) },
>         { /* Logitech G703 Hero Gaming Mouse over USB */