linux-kernel - Re: [PATCH] scripts/gdb: fix 'lx-lsmod' show the wrong size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <956205d17a304364d1026db694d544cecfe28d50.camel@mediatek.com>
Date:   Fri, 30 Jun 2023 01:01:35 +0000
From:   Kuan-Ying Lee (李冠穎) 
        <Kuan-Ying.Lee@...iatek.com>
To:     "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "p.raghav@...sung.com" <p.raghav@...sung.com>,
        "kbingham@...nel.org" <kbingham@...nel.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        "jan.kiszka@...mens.com" <jan.kiszka@...mens.com>,
        "mcgrof@...nel.org" <mcgrof@...nel.org>
CC:     Andrew Yang (楊智強) 
        <Andrew.Yang@...iatek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        Qun-wei Lin (林群崴) 
        <Qun-wei.Lin@...iatek.com>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Chinwen Chang (張錦文) 
        <chinwen.chang@...iatek.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] scripts/gdb: fix 'lx-lsmod' show the wrong size

Kindly ping, any comment?

Cc linux-modules.

Thanks,
Kuan-Ying Lee

On Tue, 2023-06-20 at 17:48 +0800, Kuan-Ying Lee wrote:
> 'lsmod' shows total core layout size, so we need to
> sum up all the sections in core layout in gdb scripts.
> 
> / # lsmod
> kasan_test 200704 0 - Live 0xffff80007f640000
> 
> Before patch:
> (gdb) lx-lsmod
> Address            Module                  Size  Used by
> 0xffff80007f640000 kasan_test             36864  0
> 
> After patch:
> (gdb) lx-lsmod
> Address            Module                  Size  Used by
> 0xffff80007f640000 kasan_test            200704  0
> 
> Fixes: b4aff7513df3 ("scripts/gdb: use mem instead of core_layout to
> get the module address")
> Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com>
> ---
>  scripts/gdb/linux/constants.py.in |  3 +++
>  scripts/gdb/linux/modules.py      | 12 +++++++++---
>  2 files changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/gdb/linux/constants.py.in
> b/scripts/gdb/linux/constants.py.in
> index 50a92c4e9984..fab74ca9df6f 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -64,6 +64,9 @@ LX_GDBPARSED(IRQ_HIDDEN)
>  
>  /* linux/module.h */
>  LX_GDBPARSED(MOD_TEXT)
> +LX_GDBPARSED(MOD_DATA)
> +LX_GDBPARSED(MOD_RODATA)
> +LX_GDBPARSED(MOD_RO_AFTER_INIT)
>  
>  /* linux/mount.h */
>  LX_VALUE(MNT_NOSUID)
> diff --git a/scripts/gdb/linux/modules.py
> b/scripts/gdb/linux/modules.py
> index 261f28640f4c..84933c4c1083 100644
> --- a/scripts/gdb/linux/modules.py
> +++ b/scripts/gdb/linux/modules.py
> @@ -73,11 +73,17 @@ class LxLsmod(gdb.Command):
>                  "        " if utils.get_long_type().sizeof == 8 else
> ""))
>  
>          for module in module_list():
> -            layout = module['mem'][constants.LX_MOD_TEXT]
> +            total_size = 0
> +            for i in range(constants.LX_MOD_TEXT,
> constants.LX_MOD_RO_AFTER_INIT + 1):
> +                layout = module['mem'][i]
> +                if i == constants.LX_MOD_TEXT:
> +                    text_addr = str(layout['base']).split()[0]
> +                total_size += layout['size']
> +
>              gdb.write("{address} {name:<19}
> {size:>8}  {ref}".format(
> -                address=str(layout['base']).split()[0],
> +                address=text_addr,
>                  name=module['name'].string(),
> -                size=str(layout['size']),
> +                size=str(total_size),
>                  ref=str(module['refcnt']['counter'] - 1)))
>  
>              t = self._module_use_type.get_type().pointer()
> -- 
> 2.18.0
>