linux-kernel - Re: [PATCH v4 18/21] pinctrl: qcom: Use qcom_scm_io_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69f8c351-9654-2b4b-b95c-cd1b26b28057@quicinc.com>
Date:   Fri, 30 Jun 2023 20:28:33 +0530
From:   Mukesh Ojha <quic_mojha@...cinc.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     <corbet@....net>, <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <keescook@...omium.org>, <tony.luck@...el.com>,
        <gpiccoli@...lia.com>, <mathieu.poirier@...aro.org>,
        <catalin.marinas@....com>, <will@...nel.org>,
        <linus.walleij@...aro.org>, <linux-doc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-hardening@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v4 18/21] pinctrl: qcom: Use qcom_scm_io_update_field()

Thanks for your time and suggestion.

On 6/28/2023 7:14 PM, Andy Shevchenko wrote:
> On Wed, Jun 28, 2023 at 3:37 PM Mukesh Ojha <quic_mojha@...cinc.com> wrote:
>>
>> Use qcom_scm_io_update_field() exported function introduced
>> in last commit.
> 
> the last
> 
> But what is that? Be more specific.
> 
> ...
> 
>> +       mask = (GENMASK(2, 0) << g->intr_target_bit);
> 
> Outer parentheses are not needed.

Will apply the changes.

-Mukesh

>