linux-kernel - Re: [PATCH] mm/hugetlb.c: fix a bug within a BUG(): inconsistent pte comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4de7fead-d0b8-8916-026d-79f37a559cde@nvidia.com>
Date:   Thu, 29 Jun 2023 19:06:51 -0700
From:   John Hubbard <jhubbard@...dia.com>
To:     James Houghton <jthoughton@...gle.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        Alex Williamson <alex.williamson@...hat.com>,
        Alexander Potapenko <glider@...gle.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        "Christian Brauner" <brauner@...nel.org>,
        Christoph Hellwig <hch@...radead.org>,
        "Daniel Vetter" <daniel@...ll.ch>, Dave Airlie <airlied@...il.com>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Ian Rogers <irogers@...gle.com>,
        Jason Gunthorpe <jgg@...pe.ca>, Jiri Olsa <jolsa@...nel.org>,
        Johannes Weiner <hannes@...xchg.org>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Lorenzo Stoakes <lstoakes@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Matthew Wilcox <willy@...radead.org>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Michal Hocko <mhocko@...nel.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Mike Rapoport <rppt@...nel.org>,
        Muchun Song <muchun.song@...ux.dev>,
        Namhyung Kim <namhyung@...nel.org>,
        Naoya Horiguchi <naoya.horiguchi@....com>,
        "Oleksandr Tyshchenko" <oleksandr_tyshchenko@...m.com>,
        Pavel Tatashin <pasha.tatashin@...een.com>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        "Ryan Roberts" <ryan.roberts@....com>,
        SeongJae Park <sj@...nel.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        Uladzislau Rezki <urezki@...il.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        Yu Zhao <yuzhao@...gle.com>
Subject: Re: [PATCH] mm/hugetlb.c: fix a bug within a BUG(): inconsistent pte
 comparison

On 6/29/23 18:50, James Houghton wrote:
> Hi John,
> 
> Good catch, and thanks for the detailed explanation. It looks like
> riscv and powerpc have equivalent problems in their huge_pte_alloc
> implementations, perhaps it's worth taking a look at those. (riscv
> looks like it has precisely the same problem except it's a WARN, but
> powerpc looks more interesting.)
> 
> Either way,
> 
> Acked-by: James Houghton <jthoughton@...gle.com>

Thanks for the ack, and yes, riscv and powerpc do look like the
same problem to me, too. I'm glad you thought to look there, as
I have fallen into tunnel vision while investigating this, heh.

OK, as long as I'm here, let me fix those up, too. I'll make those
a separate patch, because they are still in the "fragile" state,
rather than actually at the full crash state. :)


thanks,
-- 
John Hubbard
NVIDIA