[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <dc7b8b17-4338-424f-a1f1-c12fb7ea08bd@app.fastmail.com>
Date: Fri, 30 Jun 2023 17:23:24 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Zhangjin Wu" <falcon@...ylab.org>,
Thomas Weißschuh <thomas@...ch.de>,
"Willy Tarreau" <w@....eu>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
Thomas Weißschuh <linux@...ssschuh.net>
Subject: Re: [PATCH v3 03/14] selftests/nolibc: add _LARGEFILE64_SOURCE for musl
On Fri, Jun 30, 2023, at 16:44, Zhangjin Wu wrote:
> _GNU_SOURCE Implies _LARGEFILE64_SOURCE in glibc, but in musl, the
> default configuration doesn't enable _LARGEFILE64_SOURCE.
>
> From include/dirent.h of musl, getdents64 is provided as getdents when
> _LARGEFILE64_SOURCE is defined.
>
> #if defined(_LARGEFILE64_SOURCE)
> ...
> #define getdents64 getdents
> #endif
>
> Let's define _LARGEFILE64_SOURCE to fix up this compile error:
I think a better solution would be to use the normal getdents() instead
of glibc getdents64(), but then define _FILE_OFFSET_BITS=64 to tell
glibc to use the modern version of all filesystem syscalls.
Arnd
Powered by blists - more mailing lists