linux-kernel - Re: [PATCH] kdb: include header in signal handling code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <51b8b3c2-f4ac-454c-acde-e1d136139109@app.fastmail.com>
Date:   Fri, 30 Jun 2023 17:31:01 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Daniel Thompson" <daniel.thompson@...aro.org>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Jason Wessel" <jason.wessel@...driver.com>,
        kgdb-bugreport@...ts.sourceforge.net,
        "Doug Anderson" <dianders@...omium.org>,
        "Peter Zijlstra" <peterz@...radead.org>,
        "Dmitry Vyukov" <dvyukov@...gle.com>,
        "Kees Cook" <keescook@...omium.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kdb: include header in signal handling code

On Fri, Jun 30, 2023, at 17:24, Daniel Thompson wrote:
> On Wed, May 17, 2023 at 02:54:09PM +0200, Arnd Bergmann wrote:
>> diff --git a/kernel/signal.c b/kernel/signal.c
>> index 8f6330f0e9ca..d38df14f71ac 100644
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -4780,6 +4780,8 @@ void __init signals_init(void)
>>
>>  #ifdef CONFIG_KGDB_KDB
>>  #include <linux/kdb.h>
>> +#include "debug/kdb/kdb_private.h"
>> +
>
> Isn't is better to move the prototype for kdb_send_sig() into
> linux/kdb.h instead?
>
> That's what other kdb helpers spread across the kernel do
> (kdb_walk_kallsyms() for example).

Right, that is probably better here. Not sure if it's worth
reworking the branch if you already merged it, the difference
seems rather minor.

       Arnd