linux-kernel - Re: [PATCH v2 2/2] dt-bindings: leds: Read max-brightness from devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Jun 2023 10:49:28 -0600
From:   Rob Herring <robh@...nel.org>
To:     Astrid Rost <astrid.rost@...s.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, kernel@...s.com,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: leds: Read max-brightness from
 devicetree

On Fri, Jun 30, 2023 at 11:22:47AM +0200, Astrid Rost wrote:
> Add max-brightness in order to reduce the current on the connected LEDs.
> Normally, the maximum brightness is determined by the hardware, and this
> property is not required. This property is used to set a software limit.
> It could happen that an LED is made so bright that it gets damaged or
> causes damage due to restrictions in a specific system, such as mounting
> conditions. Note that led-max-microamp should be preferably used, if it
> is supported by the controller.
> 
> Signed-off-by: Astrid Rost <astrid.rost@...s.com>
> ---
>  Documentation/devicetree/bindings/leds/common.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)

The patch order is wrong. You have to define a property before you can 
use it. Otherwise,

Reviewed-by: Rob Herring <robh@...nel.org>