linux-kernel - Re: [PATCH][next] ext2: remove redundant assignment to variable desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <428ac287-6a4b-fb3c-dfa2-7043c3459ec7@gmail.com>
Date:   Fri, 30 Jun 2023 17:53:04 +0100
From:   "Colin King (gmail)" <colin.i.king@...il.com>
To:     Dan Carpenter <dan.carpenter@...aro.org>
Cc:     Jan Kara <jack@...e.com>, linux-ext4@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] ext2: remove redundant assignment to variable desc

On 30/06/2023 17:47, Dan Carpenter wrote:
> On Fri, Jun 30, 2023 at 05:30:33PM +0100, Colin Ian King wrote:
>> Variable desc is being assigned a value that is never read, the exit
>> via label found immeditely returns with no access to desc. The
>> assignment is redundant and can be removed. Cleans up clang scan
>> muild warning:
>>
>> fs/ext2/ialloc.c:297:4: warning: Value stored to 'desc' is never
>> read [deadcode.DeadStores]
>>
>> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
>> ---
>>   fs/ext2/ialloc.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
>> index a4e1d7a9c544..f50beb77d6ba 100644
>> --- a/fs/ext2/ialloc.c
>> +++ b/fs/ext2/ialloc.c
>> @@ -294,7 +294,6 @@ static int find_group_orlov(struct super_block *sb, struct inode *parent)
>>   			best_desc = desc;
>>   		}
>>   		if (best_group >= 0) {
>> -			desc = best_desc;
> 
> You should get rid of the "best_desc" variable as well.

Good point! Will send V2. Thanks Dan.

> 
> regards,
> dan carpenter
>