linux-kernel - Re: [PATCH v3] ALSA: hda/realtek: Add quirks for Unis H3C Desktop B760 & Q760

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wmzk6qwu.wl-tiwai@suse.de>
Date:   Sat, 01 Jul 2023 09:18:25 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     dengxiang <dengxiang@...china.com>
Cc:     tiwai@...e.com, yangyingliang@...wei.com, perex@...ex.cz,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ALSA: hda/realtek: Add quirks for Unis  H3C Desktop B760 & Q760

On Sat, 01 Jul 2023 08:30:51 +0200,
dengxiang wrote:
> 
> These models use NSIWAY amplifiers for internal speaker, but cannot put
> sound outside from these amplifiers. So eapd verbs are needed to initialize
> the amplifiers. They can be added during boot to get working sound out
> of internal speaker.
> 
> ---
> V3:
> - do some adjustment for eapd verbs and keep the capital letters for
>   ALC_* enums.
> v2:
> - remove warning about unused variable 'spec'.

Looks almost good, but I forgot one more thing:

> @@ -11792,6 +11800,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1b35, 0x1234, "CZC ET26", ALC662_FIXUP_CZC_ET26),
>  	SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),
>  	SND_PCI_QUIRK(0x1c6c, 0x1239, "Compaq N14JP6-V2", ALC897_FIXUP_HP_HSMIC_VERB),
> +	SND_PCI_QUIRK(0x10ec, 0x0897, "UNIS H3C X500s", ALC897_FIXUP_UNIS_H3C_X500S),
>  
>  #if 0
>  	/* Below is a quirk table taken from the old code.

The table is sorted in SSID order, so please put at the right
position.


thanks,

Takashi