linux-kernel - Re: [PATCH 0/2] mm: remove page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <604775f0-fa72-0ec4-d911-5c113fef7de1@huawei.com>
Date:   Sat, 1 Jul 2023 10:57:39 +0800
From:   "zhangpeng (AS)" <zhangpeng362@...wei.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        <sidhartha.kumar@...cle.com>, <akpm@...ux-foundation.org>,
        <wangkefeng.wang@...wei.com>, <sunnanyong@...wei.com>
Subject: Re: [PATCH 0/2] mm: remove page_rmapping()

On 2023/7/1 5:39, Matthew Wilcox wrote:

> On Fri, Jun 30, 2023 at 08:13:08PM +0800, Peng Zhang wrote:
>> From: ZhangPeng <zhangpeng362@...wei.com>
>>
>> This minor patch series remove page_rmapping() and convert the last user
>> fault_dirty_shared_page() to use a folio.
> This patch series works better if you do it in the other order.
> First convert the user, then remove the now-unused page_rmapping().
>
> It's almost always a mistake to start with "I want to remove all the
> users of API x".  You should be thinking "Here is function y that still
> uses pages; I shall convert it to use folios".

Thanks for your feedback.

I'll reverse the order of the two patches. Convert user first, then remove the now-unused page_rmapping().

Best Regards,
Peng