linux-kernel - Re: [PATCH][next] smb: client: remove redundant pointer 'server'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 1 Jul 2023 00:23:50 -0500
From:   Steve French <smfrench@...il.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Steve French <sfrench@...ba.org>,
        Paulo Alcantara <pc@...guebit.com>,
        Ronnie Sahlberg <lsahlber@...hat.com>,
        Shyam Prasad N <sprasad@...rosoft.com>,
        Tom Talpey <tom@...pey.com>, linux-cifs@...r.kernel.org,
        samba-technical@...ts.samba.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] smb: client: remove redundant pointer 'server'

merged into cifs-2.6.git for-next

On Fri, Jun 30, 2023 at 6:35 AM Colin Ian King <colin.i.king@...il.com> wrote:
>
> The pointer 'server' is assigned but never read, the pointer is
> redundant and can be removed. Cleans up clang scan build warning:
>
> fs/smb/client/dfs.c:217:3: warning: Value stored to 'server' is
> never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  fs/smb/client/dfs.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
> index 26d14dd0482e..1403a2d1ab17 100644
> --- a/fs/smb/client/dfs.c
> +++ b/fs/smb/client/dfs.c
> @@ -143,7 +143,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx)
>         struct smb3_fs_context *ctx = mnt_ctx->fs_ctx;
>         char *ref_path = NULL, *full_path = NULL;
>         struct dfs_cache_tgt_iterator *tit;
> -       struct TCP_Server_Info *server;
>         struct cifs_tcon *tcon;
>         char *origin_fullpath = NULL;
>         char sep = CIFS_DIR_SEP(cifs_sb);
> @@ -214,7 +213,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx)
>         } while (rc == -EREMOTE);
>
>         if (!rc) {
> -               server = mnt_ctx->server;
>                 tcon = mnt_ctx->tcon;
>
>                 spin_lock(&tcon->tc_lock);
> --
> 2.39.2
>


-- 
Thanks,

Steve