linux-kernel - Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a432cfe8-cfe6-6139-4487-37c08b6842b5@csgroup.eu>
Date:   Sat, 1 Jul 2023 06:30:22 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Pali Rohár <pali@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kumar Gala <galak@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y



Le 01/07/2023 à 07:46, Randy Dunlap a écrit :
> 
> 
> On 6/9/23 20:11, Randy Dunlap wrote:
>> Hi--
>>
>> On 5/16/23 11:54, Pali Rohár wrote:
>>> On Tuesday 16 May 2023 08:28:54 Randy Dunlap wrote:
>>>> In a randconfig with CONFIG_SERIAL_CPM=m and
>>>> CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
>>>> ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined!
>>>>
>>>> Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
>>>> SERIAL_CPM=y.
>>>>
>>>> Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.")
>>>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>>>> Cc: Scott Wood <scottwood@...escale.com>
>>>> Cc: Kumar Gala <galak@...nel.crashing.org>
>>>> Cc: "Pali Rohár" <pali@...nel.org>
>>>> Cc: Michael Ellerman <mpe@...erman.id.au>
>>>> Cc: Nicholas Piggin <npiggin@...il.com>
>>>> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
>>>> Cc: linuxppc-dev@...ts.ozlabs.org
>>>
>>> Looks good,
>>>
>>> Reviewed-by: Pali Rohár <pali@...nel.org>
>>
>> I'm still seeing this build error in linux-next even with other (PPC) CPM
>> patches applied.
>>
> 
> Patchwork shows status as Superseded:
> 
> http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20230516152854.22465-1-rdunlap@infradead.org/
> 
> but I don't understand why or by what.

Neither do I. I must have made a mistake but I can't remember.

> 
> I'm going to resubmit the patch now.

Fine, then the previous is really superseeded now.

Christophe

> 
> 
>>>
>>>> ---
>>>>   arch/powerpc/Kconfig.debug |    2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug
>>>> --- a/arch/powerpc/Kconfig.debug
>>>> +++ b/arch/powerpc/Kconfig.debug
>>>> @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x
>>>>   
>>>>   config PPC_EARLY_DEBUG_CPM
>>>>   	bool "Early serial debugging for Freescale CPM-based serial ports"
>>>> -	depends on SERIAL_CPM
>>>> +	depends on SERIAL_CPM=y
>>>>   	help
>>>>   	  Select this to enable early debugging for Freescale chips
>>>>   	  using a CPM-based serial port.  This assumes that the bootwrapper
>>
>