linux-kernel - Re: [PATCH] smb: client: remove unused variable 'server'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAH2r5mtuyXgfkNk65y0JjkUfaxxUuWHYOPuAXO8f_sp4_VDFAA@mail.gmail.com>
Date:   Sun, 2 Jul 2023 18:36:19 -0500
From:   Steve French <smfrench@...il.com>
To:     Tom Rix <trix@...hat.com>
Cc:     sfrench@...ba.org, pc@...guebit.com, lsahlber@...hat.com,
        sprasad@...rosoft.com, tom@...pey.com, linux-cifs@...r.kernel.org,
        samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org,
        Colin Ian King <colin.i.king@...il.com>
Subject: Re: [PATCH] smb: client: remove unused variable 'server'

Good catch - but this was removed a few days ago by Colin's patch

smfrench@...rench-ThinkPad-P52:~/cifs-2.6$ git log fs/smb/client/dfs.c
commit dfbf0ee092a5d7a9301c81e815b5e50b7c0aeeda
Author: Colin Ian King <colin.i.king@...il.com>
Date:   Fri Jun 30 12:33:37 2023 +0100

    smb: client: remove redundant pointer 'server'

    The pointer 'server' is assigned but never read, the pointer is
    redundant and can be removed. Cleans up clang scan build warning:

    fs/smb/client/dfs.c:217:3: warning: Value stored to 'server' is
    never read [deadcode.DeadStores]

    Signed-off-by: Colin Ian King <colin.i.king@...il.com>
    Signed-off-by: Steve French <stfrench@...rosoft.com>

On Sun, Jul 2, 2023 at 8:43 AM Tom Rix <trix@...hat.com> wrote:
>
> gcc with W=1 reports
> fs/smb/client/dfs.c: In function ‘__dfs_mount_share’:
> fs/smb/client/dfs.c:146:33: error: variable ‘server
>   set but not used [-Werror=unused-but-set-variable]
>   146 |         struct TCP_Server_Info *server;
>       |                                 ^~~~~~
>
> This variable is not used, so remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  fs/smb/client/dfs.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/fs/smb/client/dfs.c b/fs/smb/client/dfs.c
> index 26d14dd0482e..1403a2d1ab17 100644
> --- a/fs/smb/client/dfs.c
> +++ b/fs/smb/client/dfs.c
> @@ -143,7 +143,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx)
>         struct smb3_fs_context *ctx = mnt_ctx->fs_ctx;
>         char *ref_path = NULL, *full_path = NULL;
>         struct dfs_cache_tgt_iterator *tit;
> -       struct TCP_Server_Info *server;
>         struct cifs_tcon *tcon;
>         char *origin_fullpath = NULL;
>         char sep = CIFS_DIR_SEP(cifs_sb);
> @@ -214,7 +213,6 @@ static int __dfs_mount_share(struct cifs_mount_ctx *mnt_ctx)
>         } while (rc == -EREMOTE);
>
>         if (!rc) {
> -               server = mnt_ctx->server;
>                 tcon = mnt_ctx->tcon;
>
>                 spin_lock(&tcon->tc_lock);
> --
> 2.27.0
>


-- 
Thanks,

Steve