[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230702183409.0000021f@Huawei.com>
Date: Sun, 2 Jul 2023 18:34:09 +0800
From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
To: Waqar Hameed <waqar.hameed@...s.com>
CC: Jonathan Cameron <jic23@...nel.org>, <devicetree@...r.kernel.org>,
"Conor Dooley" <conor+dt@...nel.org>,
Lars-Peter Clausen <lars@...afoo.de>,
<linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
Rob Herring <robh+dt@...nel.org>, <kernel@...s.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
<kernel@...ts.axis.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: proximity: Add bindings for
Murata IRS-D200
On Mon, 19 Jun 2023 12:41:06 +0200
Waqar Hameed <waqar.hameed@...s.com> wrote:
> On Sat, Jun 17, 2023 at 13:55 +0100 Jonathan Cameron <jic23@...nel.org> wrote:
>
> > On Fri, 16 Jun 2023 17:10:42 +0200
> > Waqar Hameed <waqar.hameed@...s.com> wrote:
> >
> >> Murata IRS-D200 is a PIR sensor for human detection. It uses the I2C bus
> >> for communication with interrupt support. Add devicetree bindings
> >> requiring the compatible string, I2C slave address (reg) and interrupts.
> >>
> >> Signed-off-by: Waqar Hameed <waqar.hameed@...s.com>
> >
> > This device will have some power supplies, so I'd expect those to be both
> > listed and marked as required (maybe some are optional?)
>
> Right, will add that here (and call `devm_regulator_get_enable()` in
> driver's probe).
>
> [...]
>
> >> +required:
> >> + - compatible
> >> + - reg
> >> + - interrupts
> >
> > If it is possible to remove interrupts from requires - and hence have
> > at least a partly functional driver doing basic reading of the sensor
> > then that is usually a good idea. Far too many board designers seem
> > to decide that they don't need to wire up interrupt liness
> > If it's really hard then don't worry too much.
>
> I see. It would be possible, but would also require some work. Let's
> leave it for now then?
Sure - as long as you review the patches when they come in :)
Jonathan
Powered by blists - more mailing lists