linux-kernel - Re: [PATCH v3] perf evsel amd: Fix IBS error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM9d7ciV--mPi_MFQdsa8eoGp82NB0B5BmVccP_kMB65wGJafg@mail.gmail.com>
Date:   Sat, 1 Jul 2023 18:03:30 -0700
From:   Namhyung Kim <namhyung@...nel.org>
To:     Ravi Bangoria <ravi.bangoria@....com>
Cc:     acme@...nel.org, peterz@...radead.org, irogers@...gle.com,
        jolsa@...nel.org, adrian.hunter@...el.com,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        sandipan.das@....com, ananth.narayan@....com,
        santosh.shukla@....com
Subject: Re: [PATCH v3] perf evsel amd: Fix IBS error message

On Sat, Jul 1, 2023 at 11:17 AM Namhyung Kim <namhyung@...nel.org> wrote:
>
> Hi Ravi,
>
> On Fri, Jun 30, 2023 at 1:53 AM Ravi Bangoria <ravi.bangoria@....com> wrote:
> >
> > AMD IBS can do per-process profiling[1] and is no longer restricted to
> > per-cpu or systemwide only. Remove stale error message. Also, checking
> > just exclude_kernel is not sufficient since IBS does not support any
> > privilege filters. So include all exclude_* checks. And finally, move
> > these checks under tools/perf/arch/x86/ from generic code.
> >
> > Before:
> >   $ sudo ./perf record -e ibs_op//k -C 0
> >   Error:
> >   AMD IBS may only be available in system-wide/per-cpu mode.  Try
> >   using -a, or -C and workload affinity
> >
> > After:
> >   $ sudo ./perf record -e ibs_op//k -C 0
> >   Error:
> >   AMD IBS doesn't support privilege filtering. Try again without
> >   the privilege modifiers (like 'k') at the end.
> >
> > [1] https://git.kernel.org/torvalds/c/30093056f7b2
> >
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@....com>
>
> Acked-by: Namhyung Kim <namhyung@...nel.org>

Applied to perf-tools-next, thanks!