linux-kernel - RE: [PATCH 2/3] drm/panel: ld9040: Register a backlight device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f0c01d9ae09$0d3a17f0$27ae47d0$@samsung.com>
Date:   Tue, 4 Jul 2023 08:49:48 +0900
From:   대인기/Tizen Platform Lab(SR)/삼성전자 
        <inki.dae@...sung.com>
To:     "'Paul Cercueil'" <paul@...pouillou.net>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@...aro.org>,
        "'Rob Herring'" <robh+dt@...nel.org>,
        "'Conor Dooley'" <conor+dt@...nel.org>,
        "'Alim Akhtar'" <alim.akhtar@...sung.com>,
        "'Neil Armstrong'" <neil.armstrong@...aro.org>,
        "'Sam Ravnborg'" <sam@...nborg.org>
Cc:     <devicetree@...r.kernel.org>, <linux-samsung-soc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 2/3] drm/panel: ld9040: Register a backlight device

Hi,

> -----Original Message-----
> From: dri-devel <dri-devel-bounces@...ts.freedesktop.org> On Behalf Of
> Paul Cercueil
> Sent: Tuesday, July 4, 2023 6:47 AM
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>; Rob Herring
> <robh+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Alim Akhtar
> <alim.akhtar@...sung.com>; Neil Armstrong <neil.armstrong@...aro.org>; Sam
> Ravnborg <sam@...nborg.org>
> Cc: devicetree@...r.kernel.org; linux-samsung-soc@...r.kernel.org; linux-
> kernel@...r.kernel.org; dri-devel@...ts.freedesktop.org; Paul Cercueil
> <paul@...pouillou.net>; linux-arm-kernel@...ts.infradead.org
> Subject: [PATCH 2/3] drm/panel: ld9040: Register a backlight device
> 
> Register a backlight device to be able to switch between all the gamma
> levels.
> 
> Signed-off-by: Paul Cercueil <paul@...pouillou.net>
> ---
>  drivers/gpu/drm/panel/panel-samsung-ld9040.c | 40 ++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-samsung-ld9040.c
> b/drivers/gpu/drm/panel/panel-samsung-ld9040.c
> index 7fd9444b42c5..b4f87d6244cb 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-ld9040.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-ld9040.c
> @@ -8,6 +8,7 @@
>   * Andrzej Hajda <a.hajda@...sung.com>
>  */
> 
> +#include <linux/backlight.h>
>  #include <linux/delay.h>
>  #include <linux/gpio/consumer.h>
>  #include <linux/module.h>
> @@ -311,8 +312,40 @@ static int ld9040_parse_dt(struct ld9040 *ctx)
>  	return 0;
>  }
> 
> +static int ld9040_bl_update_status(struct backlight_device *dev)
> +{
> +	struct ld9040 *ctx = dev_get_drvdata(&dev->dev);
> +
> +	ctx->brightness = dev->props.brightness;
> +	ld9040_brightness_set(ctx);
> +
> +	return 0;
> +}
> +
> +static int ld9040_bl_get_intensity(struct backlight_device *dev)
> +{
> +	if (dev->props.fb_blank == FB_BLANK_UNBLANK &&

fb_blank member is deprecated according to the description of backlight.h
file so you could drop above condition I think.

Thanks,
Inki Dae