linux-kernel - Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and FB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <04fa72f3-d6ca-bd68-7ed9-57151c1877df@suse.de>
Date:   Mon, 3 Jul 2023 09:52:56 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Javier Martinez Canillas <javierm@...hat.com>,
        linux-kernel@...r.kernel.org
Cc:     linux-fbdev@...r.kernel.org, Randy Dunlap <rdunlap@...radead.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Helge Deller <deller@....de>, x86@...nel.org,
        dri-devel@...ts.freedesktop.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>, Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH v2 1/2] fbdev: Split frame buffer support in FB and
 FB_CORE symbols

Hi

Am 03.07.23 um 09:46 schrieb Javier Martinez Canillas:
> Thomas Zimmermann <tzimmermann@...e.de> writes:
> 
> Hello Thomas,
> 
> Thanks for your review.
> 
>> Hi
>>
>> Am 01.07.23 um 23:44 schrieb Javier Martinez Canillas:
> 
> [...]
> 
>>>    
>>> +menuconfig FB_CORE
>>> +	tristate "Core support for frame buffer devices"
>>
>> With the text, this is visible; as others noted.
>>
> 
> Yes, I misremembered what made a Kconfig symbol non-visible, and thought
> that was just the lack of a help section but forgot to remove the prompt.
> 
> This is already fixed in v3.
> 
>>> +
>>>    menuconfig FB
>>> -	tristate "Support for frame buffer devices"
>>> +	tristate "Support for frame buffer device drivers"
>>
>> Just keep the text as-is.
>>
> 
> I disagree. Because we are slightly changing the Kconfig symbol semantics
> here, for instance CONFIG_FB_CORE + CONFIG_DRM_FBDEV_EMULATION will also
> provide a frame buffer device (and with CONFIG_FB_DEVICE, will be exposed
> to user-space as a /dev/fb? device).
> 
> So now CONFIG_FB is really about allowing the native fbdev drivers to be
> enabled. That's why I'm changing the prompt text to make that more clear.
> 
> [...]
> 
>>>    config FB_DEVICE
>>>    	bool "Provide legacy /dev/fb* device"
>>> -	depends on FB
>>> +	select FB_CORE
>>
>> This should depend on FB_CORE.
>>
> 
> Yes, already fixed in v3 too. I did a select to prevent symbol circular
> dependencies but doing that lead to CONFIG_FB_CORE=y even if CONFIG_DRM
> was set as a module.
> 
> But with the "select FB_CORE if DRM_FBDEV_EMULATION" in the DRM symbol as
> Arnd suggested, I was able to have FB_DEVICE to depend on FB_CORE again.

BTW, where does this item now show up in the menu? It used to be in the 
framebuffer menu. It's now in the graphics-drivers menu?

Best regards
Thomas

> 
>> Best regards
>> Thomas
>>
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)