linux-kernel - Re: + mm-page_alloc-use-write_seqlock_irqsave-instead-write_seqlock-local_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZKKAL9o4lC1Iw5SP@dhcp22.suse.cz>
Date:   Mon, 3 Jul 2023 10:00:47 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     linux-kernel@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>, bigeasy@...utronix.de,
        pmladek@...e.com, will@...nel.org, tglx@...utronix.de,
        peterz@...radead.org, mingo@...hat.com,
        mgorman@...hsingularity.net, longman@...hat.com,
        lgoncalv@...hat.com, john.ogness@...utronix.de, david@...hat.com,
        boqun.feng@...il.com, mm-commits@...r.kernel.org
Subject: Re: +
 mm-page_alloc-use-write_seqlock_irqsave-instead-write_seqlock-local_irq_save.patch
 added to mm-unstable branch

On Mon 03-07-23 09:09:46, Tetsuo Handa wrote:
> Nacked-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> 
> because of https://lkml.kernel.org/r/a1c559b7-335e-5401-d167-301c5b1cd312@I-love.SAKURA.ne.jp .

This is not really productive approach! You are rising non-material
concerns you haven't proven to be real. This is blocking otherwise
useful fix. I am completely fine recording your nack with a reference to
your concern should we ever trip over your concerns and so we can easily
revert and find a different solution but I do not believe this should
stand in the way in the fix.

Now concerning the patch 1 in the series, I do agree this should be
passing through the lockdep maintainers. But this fix is not really
dependent on it.

> On 2023/07/03 8:40, Andrew Morton wrote:
> > The patch titled
> >      Subject: mm/page_alloc: use write_seqlock_irqsave() instead write_seqlock() + local_irq_save().
> > has been added to the -mm mm-unstable branch.  Its filename is
> >      mm-page_alloc-use-write_seqlock_irqsave-instead-write_seqlock-local_irq_save.patch
> > 
> > This patch will shortly appear at
> >      https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-page_alloc-use-write_seqlock_irqsave-instead-write_seqlock-local_irq_save.patch
> > 
> > This patch will later appear in the mm-unstable branch at
> >     git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > 
> > Before you just go and hit "reply", please:
> >    a) Consider who else should be cc'ed
> >    b) Prefer to cc a suitable mailing list as well
> >    c) Ideally: find the original patch on the mailing list and do a
> >       reply-to-all to that, adding suitable additional cc's
> > 
> > *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> > 
> > The -mm tree is included into linux-next via the mm-everything
> > branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> > and is updated there every 2-3 working days

-- 
Michal Hocko
SUSE Labs