linux-kernel - Re: [PATCH v2 3/4] perf/arm_cspmu: Clean up ACPI dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdU7kiGni_T1mRU7EC-8sQn8EjhND1-POc2h2V4V8Oeuqg@mail.gmail.com>
Date:   Mon, 3 Jul 2023 11:21:03 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Robin Murphy <robin.murphy@....com>
Cc:     will@...nel.org, mark.rutland@....com, suzuki.poulose@....com,
        bwicaksono@...dia.com, ilkka@...amperecomputing.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH v2 3/4] perf/arm_cspmu: Clean up ACPI dependency

Hi Robin,

On Mon, Jun 5, 2023 at 7:05 PM Robin Murphy <robin.murphy@....com> wrote:
> Build-wise, the ACPI dependency consists of only a couple of things
> which could probably stand being factored out into ACPI helpers anyway.
> However for the immediate concern of working towards Devicetree support
> here, it's easy enough to make a few tweaks to contain the affected code
> locally, such that we can relax the Kconfig dependency.
>
> Reviewed-and-Tested-by: Suzuki K Poulose <suzuki.poulose@....com>
> Reviewed-by: Ilkka Koskinen <ilkka@...amperecomputing.com>
> Signed-off-by: Robin Murphy <robin.murphy@....com>

Thanks for your patch, which is now commit f9bd34e3753ea8f1
("perf/arm_cspmu: Clean up ACPI dependency") upstream.

> --- a/drivers/perf/arm_cspmu/Kconfig
> +++ b/drivers/perf/arm_cspmu/Kconfig
> @@ -4,8 +4,7 @@
>
>  config ARM_CORESIGHT_PMU_ARCH_SYSTEM_PMU
>         tristate "ARM Coresight Architecture PMU"
> -       depends on ARM64 && ACPI
> -       depends on ACPI_APMT || COMPILE_TEST
> +       depends on ARM64 || COMPILE_TEST

>From looking at the code, the "arm-cs-arch-pmu" platform device can
be instantiated only through ACPI.  So I think it is a bit premature to
relax the dependency, and expose this question to people configuring
an ARM64 kernel without ACPI/APMT support.

Am I missing something?
Thanks!

>         help
>           Provides support for performance monitoring unit (PMU) devices
>           based on ARM CoreSight PMU architecture. Note that this PMU

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds